chore: Move copied files back to geth fork #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a couple references to the original string formatted EIPS in the README.md. |
vladjdk
requested changes
Apr 10, 2025
| @@ -16,7 +16,7 @@ message Params { | |||
| // enable_create and enable call have been deprecated | |||
| reserved 2, 3; | |||
| // extra_eips defines the additional EIPs for the vm.Config | |||
| repeated string extra_eips = 4 [ | |||
| repeated int64 extra_eips = 4 [ | |||
There was a problem hiding this comment.
noting this down as something that would break existing chains as a reminder that they'll need to migrate types
| @@ -69,6 +69,7 @@ func EvmAppOptions(chainID string) error { | |||
| ethCfg := evmtypes.DefaultChainConfig(chainID) | |||
|
|
|||
| err = evmtypes.NewEVMConfigurator(). | |||
| WithExtendedEips(cosmosEVMActivators). | |||
There was a problem hiding this comment.
The original didn't have the EIPs enabled? Interesting
vladjdk
approved these changes
Apr 11, 2025
Eric-Warehime
added a commit
that referenced
this pull request
Apr 17, 2025
* chore: add docs to readme (#60) Link mention to Cosmos EVM docs' page on the main readme of the repository. * Fix: Correct JSON path for setting max_gas in genesis (#39) Co-authored-by: Vlad J <[email protected]> * chore: Move copied files back to geth fork (#40) * Change all the things * Fix test * Remove activators nolint * Fix test * Update readme * Fix readme lint * chore: utest -> atest (#25) * utest -> atest * example chain script fix * fix node script --------- Co-authored-by: Eric Warehime <[email protected]> * fix name() query on native ERC20 failing out (#72) * fix name() query on native ERC20 failing out * fix indent * lint fix * lint * tab character * another hidden tab * static link (#77) solving the problem using different versions of glibc * Remove comma from Makefile phony (#78) * refactor: Remove old params object from x/feemarket (#83) * Remove old params object from feemarket * Add changelog entry --------- Co-authored-by: Nico Poggi <[email protected]> Co-authored-by: xosnet <[email protected]> Co-authored-by: Vlad J <[email protected]> Co-authored-by: valli_0x <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #28
This should be reviewed in tandem with cosmos/go-ethereum#1 which introduces all of the changes made to the copied files as patches to upstream (mostly around the custom EIP feature).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md