Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire channel query server v2 #7537

Merged

Conversation

gjermundgaraba
Copy link
Contributor

Description

I have not tested this yet, just putting up the PR in the hopes that the tests pass. If not, I will look into it properly tomorrow 😅

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me!

@DimitrisJim
Copy link
Contributor

oh, though might need to register it too to in RegisterGRPCGatewayRoutes?

@gjermundgaraba
Copy link
Contributor Author

oh, though might need to register it too to in RegisterGRPCGatewayRoutes?

Shit, yes. Added.

Copy link

sonarcloud bot commented Nov 6, 2024

@DimitrisJim
Copy link
Contributor

(p.s feel free to merge with single approval!)

@gjermundgaraba gjermundgaraba merged commit c7670b3 into feat/ibc-eureka Nov 6, 2024
65 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/wire-channel-query-server-v2 branch November 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants