Cvs planner #11
Draft
Cvs planner #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ease out shard management in the new shard dealer Change-Id: I7568b27a8e474f6f56e58da8ed5d7a69b75de8ee Signed-off-by: Dhruvil Shah <[email protected]>
* pass config from various sources to planner * initialise shard dealer in solution Change-Id: I229074408a72d869d2efaa0f7e3e63d9b5ffd0e6 Signed-off-by: Dhruvil Shah <[email protected]>
* implement pass 0:
if all nodes are under minimum shard limit then we create
new alternate shards
Change-Id: I20b943c1dee46e7f6bbdbf02772b4294932aadd2
Signed-off-by: Dhruvil Shah <[email protected]>
Change-Id: I0e5158ebc9cb4b80f745dd67c66a9a1a47f01eb9 Signed-off-by: Dhruvil Shah <[email protected]>
* rename nodeToSlotCount to nodeToShardCount * also fix a bug in calculating nodeToShardCount where it ends up counting partitions on node rather than shards on node Change-Id: Id0abdf01e303c40f265f1cb9effad14345c6e616 Signed-off-by: Dhruvil Shah <[email protected]>
* if total shards across all nodes are under shard capacity then we should go ahead and create a new shard * also fix a bug in calculating, shardsUnderSoftLimit Change-Id: I862b8091b8ae731e42d70796829216631a11a2b6 Signed-off-by: Dhruvil Shah <[email protected]>
* add new tests for pass-2 Change-Id: I2470bb7fb052d08cc73ca626a0fe17e8a95cd6d7 Signed-off-by: Dhruvil Shah <[email protected]>
find a common slot across all nodes and use it for shard placement Change-Id: I621b6bdc9869d03b41c8f32d23a829be6f3060b5 Signed-off-by: Dhruvil Shah <[email protected]>
Change-Id: I53e65b42ee5f8b97fd08dc4bbda5053feb924119 Signed-off-by: Dhruvil Shah <[email protected]>
* add type aliases for better reading * add alternateShardIDGenerator as parameter to shard dealer * define NewShardDealer2 with default shard id generator Change-Id: I1d4c68c0121fa8a99f70823d9798aea0c178c301 Signed-off-by: Dhruvil Shah <[email protected]>
* currently, shard dealer would only consider defnID while assigning slots; if we see a defnID again we would reuse a slot * this would cause all the partitions on a definition to goto the same slot; * this does not scale well and we want partitions to be moved around easily * fix by replacing the indexSlots with partition slots Change-Id: Ib0cdcf343d8d8d22b953ae0679adf006840eb312 Signed-off-by: Dhruvil Shah <[email protected]>
NightWing1998
force-pushed
the
cvs-planner2
branch
from
018bced
to
328fd4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.