Skip to content

chore: ensure github-actions detection by npm can work #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2025
Merged

chore: ensure github-actions detection by npm can work #5842

merged 4 commits into from
Aug 7, 2025

Conversation

@louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Aug 6, 2025 •
edited
Loading

https://coveord.atlassian.net/browse/KIT-4720
and + some for Quantic, just playin' safe.

Fix-it-twice maybe in vercel/turborepo#10740

@louis-bompart louis-bompart requested a review from a team as a code owner August 6, 2025 19:54
@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Aug 6, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 253.7 253.7 0
commerce 366.4 366.4 0
search 426 426 0
insight 417 417 0
recommendation 264.5 264.5 0
ssr 419.5 419.5 0
ssr-commerce 383.6 383.6 0
ssr-commerce-next 383.6 383.6 0
ssr-next 419.5 419.5 0

@louis-bompart louis-bompart enabled auto-merge August 6, 2025 21:36
@louis-bompart louis-bompart added this pull request to the merge queue Aug 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2025
@louis-bompart louis-bompart added this pull request to the merge queue Aug 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2025
@louis-bompart louis-bompart enabled auto-merge August 7, 2025 00:10
@louis-bompart louis-bompart added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit ef6806c Aug 7, 2025
147 of 150 checks passed
@louis-bompart louis-bompart deleted the ci/passthru-env branch August 7, 2025 08:26
@louis-bompart louis-bompart mentioned this pull request Aug 8, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2025
@louis-bompart
chore: allow npm env for promote/tag update (#5852)
eef2bfb 
[coveord.atlassian.net/browse/KIT-4720](https://coveord.atlassian.net/browse/KIT-4720)
Same as #5842 for promote.
Tho, I don't think we need the OIDC/GitHub variables, because the
provenance is set when the version is published. Here, we are just
moving the "latest" sticker from one place to another
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dxui

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dxui

@vhilotii-coveo vhilotii-coveo Awaiting requested review from vhilotii-coveo vhilotii-coveo is a code owner automatically assigned from coveo/dxui

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@louis-bompart @alexprudhomme