[feat][backend] Add openapi src params.#441
Conversation
Change-Id: I09011617cf91421324b9336eb4965b1e709a4b5c
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 73.77% 73.77% -0.01%
==========================================
Files 625 625
Lines 64805 64818 +13
==========================================
+ Hits 47813 47822 +9
- Misses 13748 13750 +2
- Partials 3244 3246 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Change-Id: I367fa09e23fe05f4f8d015d70fbd3e57afad5183
idl/thrift/coze/loop/observability/coze.loop.observability.openapi.thrift
Show resolved
Hide resolved
CozeLoop
left a comment
There was a problem hiding this comment.
Aime backend Go review: adding openapi src header wiring for observability tracing.
All inspected changes are low-risk from correctness, concurrency, and performance perspectives. Adding Extra.src is backward compatible and only surfaces additional metadata into the collector layer.
Inline comments will mark the touched call sites and type signatures as "No risk change" for traceability.
CozeLoop
left a comment
There was a problem hiding this comment.
Aime backend Go CR summary for PR #441
All touched observability OpenAPI entrypoints now thread an optional Extra.src field from the new thrift IDL through to the collector interface. The additional src dimension is read from an HTTP header and does not alter existing query semantics, authorization, or rate limiting logic.
I reviewed the following areas:
- Thrift IDL: new
Extrastruct andextrafield on four OpenAPI requests use high, optional field IDs and keepBaseat 255, so wire format remains backward compatible. - Generated kitex code (types, validators, fast-path codecs): changes are mechanical and consistent with existing patterns.
- Application layer (
OpenAPIApplication): newExtra.srcis read safely (nil-checked) and only passed to the collector; metrics remain unchanged; no new error handling, concurrency, or performance risks identified. - Domain & infra collector:
ICollectorProviderand its implementation gained asrcparameter; all call sites and mocks compile against the new signature, and the implementation remains a no-op as before.
Given the narrow scope and additive nature of these changes, I consider this PR low-risk. Inline comments are marked as "No risk change" on the modified call sites, interface signatures, and IDL definition for traceability.
backend/modules/observability/domain/component/collector/event_collector.go
Show resolved
Hide resolved
idl/thrift/coze/loop/observability/coze.loop.observability.openapi.thrift
Show resolved
Hide resolved
Change-Id: Id7fed1e456df83f0c45610e878a70891e3d9cdd6
Change-Id: I09011617cf91421324b9336eb4965b1e709a4b5c
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes