feat(Layout): Simplify the approach and make it compliant with v-tables #2820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Unchanged files (1)
Total files change -220B -0.44% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
force-pushed
the
feat/layout
branch
3 times, most recently
from
98e60a0 to
41b7884
Compare
Add dialog in layout to better simulate app behavior. Virtualized tables use `height: 100%` but it didn't work with the old layout. So we need to change the structure to allow `height: 100%` on content.
zatteo
reviewed
Jul 28, 2025
| )} | ||
| className={cx(className, styles['o-layout-main'], { | ||
| [styles['o-layout-main-2panes']]: !monoColumn, | ||
| [styles[`o-layout-main-topbar`]]: withTopBar && !isDesktop |
There was a problem hiding this comment.
Sure about the !isDesktop ? If this class is responsible of moving the content down of the size of the topbar we need it in desktop too?
There was a problem hiding this comment.
I don't remember clearly why I did that this way, but after checking the result in the doc, the structure is different between mobile and desktop. I suppose because of the cozy-bar is different too. In desktop it acts like a div and take the place normally, but it probably doesn't in mobile
zatteo
approved these changes
Jul 28, 2025
|
🎉 This PR is included in version 127.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.