fix: readlink failure returns undef for correct list context#253
Merged
atoomic merged 1 commit intocpanel:masterfrom Feb 28, 2026
Merged
Conversation
CORE::readlink returns undef on failure. Our __readlink override used bare `return;` which returns an empty list in list context instead of (undef). This caused `my @ret = readlink($non_link)` to return () instead of (undef), breaking list-context callers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
__readlinkfailure paths now usereturn undef;instead of barereturn;.Why
CORE::readlinkreturnsundefon failure. Barereturn;produces an empty list()in list context instead of(undef), which breaks callers that domy @ret = readlink(...)— they get 0 elements instead of 1 undefined element.Same pattern as the
__openfix in PR #244.How
Changed 3 bare
return;statements toreturn undef;in__readlink:Testing
Added 2 tests in
t/readlink.tverifying list-context returns(undef)for both non-link and non-existent cases.🤖 Generated with Claude Code