Refactor code to use new common utilities for HTML#550
Merged
jwakely merged 10 commits intocplusplus:masterfrom Feb 24, 2026
Merged
Refactor code to use new common utilities for HTML#550jwakely merged 10 commits intocplusplus:masterfrom
jwakely merged 10 commits intocplusplus:masterfrom
Conversation
jwakely
force-pushed
the
html-utils
branch
2 times, most recently
from
1604bf5 to
f55672d
Compare
Member
|
Looks good to me. I successfully checked it out, rebuild everything and could also build a list locally |
jwakely
commented
Feb 22, 2026
jwakely
commented
Feb 22, 2026
jwakely
commented
Feb 22, 2026
jwakely
changed the title
jwakely
force-pushed
the
html-utils
branch
2 times, most recently
from
2c2f467 to
022fd36
Compare
Replace some manual string manipulation in mailing_info.cpp.
The struct members are the "outer XML" and "inner XML" which are terms commonly used in DOM APIs (alternative names I considered are "element" and "content", to match the XML specs). Also rename get_element_contents to get_element_content, which matches the term used in XML specs for the data between the STag and ETag.
Return std::nullopt instead of throwing in the utility functions. Make callers check and throw (as was the case before changing them to use the new utility functions).
Require the attribute name to be provided by the caller, instead of just processing the first attribute found. This allows the lambda to be defined in terms of the lwg::get_attribute_of utility.
Use the new utility functions to simplify parsing <section> and <priority> elements.
Make static pattern rule for self tests more flexible. Use LINK.C implicit rule for linking C++ programs.
jwakely
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.