-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable MacOS runner #7753
Re-enable MacOS runner #7753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on main and testing.
The "gramwrite" spelling error was not flagged by LaTeX; strange. Is this ever invoked?
The commit message of the main change has a typo "exract".
source/macros.tex
Outdated
|
||
\NewEnviron{simplebnf}{\begin{ncsimplebnf}% | ||
\BODY% | ||
\gramwrite{\string\begin{ncsimplebnf}\meaningbody\BODY\string\end{ncsimplebnf}}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\gramwrite{\string\begin{ncsimplebnf}\meaningbody\BODY\string\end{ncsimplebnf}}% | |
\gramWrite{\string\begin{ncsimplebnf}\meaningbody\BODY\string\end{ncsimplebnf}}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, "simpebnf" is unused throughout the standard. Please remove.
(We only use "ncsimplebnf".)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I suppose we should rename ncsimplebnf
and ncrebnf
? We can drop the "nc" there if we are reasonably sure that bnf
is the only environment we'll ever want extracted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's plausible to assume we only ever want "bnf" to be extracted; everything else are either grammar quotes or non-C++ grammar things (such as regex).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense. Yeah, in that case a global renaming would be plausible (but is by no means urgent or important).
"diffpdf" in "Appearance" mode shows no differences. Please merge after fixing the minor findings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check.yml commit has an odd summary: "MacOS Linux runner"
Was "Linux" meant to say something else?
@jwakely Yeah, sorry, the genesis of this PR is a bit chaotic. I'll apply some of the commits directly and repurpose/rewrite the runner based things appropriately. Thanks! |
(I deleted the wrong word. Initially the commit said "Update MacOS and Linux runners". I meant to delete "Linux", not "Update".) |
The path of the `sed` binary on MacOS has changed going from Intel (macos-13) to M1 (macos-15).
No description provided.