Skip to content

Rename label expr.ass.overlap to expr.assign.overlap #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

jensmaurer
Copy link
Member

No description provided.

@jensmaurer jensmaurer added the ub-ifndr UB and IFNDR Annex label Apr 13, 2025
@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 14, 2025

Hm, we did end up recording the other changes, too (

draft/source/xrefdelta.tex

Lines 482 to 484 in 8792e55

% https://github.com/cplusplus/draft/pull/7524
\movedxref{expr.ass}{expr.assign}
\movedxref{over.ass}{over.assign}
), so maybe we should also record this one?

@tkoeppe tkoeppe self-requested a review April 14, 2025 11:05
@jensmaurer
Copy link
Member Author

Note the "ub-ifndr" label: This is for preparing a pull request to create a UB/IFNDR Annex. I'm guessing we'll just squash everything before merging to the Working Draft.
Plus, these are labels for UB, which are currently invisible in the generated PDF. So, recording changes for them in xrefdelta seems triple out-of-scope.

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 14, 2025

Oh, I see, you're not merging into main. Sure.

@tkoeppe tkoeppe merged commit 2be6676 into cplusplus:ub-ifndr Apr 14, 2025
2 checks passed
@jensmaurer jensmaurer deleted the ub-3 branch April 14, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ub-ifndr UB and IFNDR Annex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants