Skip to content

Improve error handling in run_thread#881

Open
MMenshikh wants to merge 2 commits intocqfn:masterfrom
MMenshikh:improve-error-handling
Open

Improve error handling in run_thread#881
MMenshikh wants to merge 2 commits intocqfn:masterfrom
MMenshikh:improve-error-handling

Conversation

@MMenshikh
Copy link

@MMenshikh MMenshikh commented Jul 20, 2025

This PR improves error reporting in the run_thread function. Now any exceptions during Java file analysis are printed to the console instead of silently failing.

This helps developers debug pattern failures or malformed Java files.

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling during concurrent tasks to prevent interruptions from individual errors.
  • Refactor

    • Updated result processing to return a complete list of outcomes instead of delivering them one by one.

@coderabbitai
Copy link

coderabbitai bot commented Jul 20, 2025

"""

Walkthrough

The run_thread function in aibolit/__main__.py was refactored to collect results from concurrent tasks into a list and return them all at once, instead of yielding results one by one. Exception handling was added to catch and print errors from individual tasks without interrupting the processing of others.

Changes

File(s) Change Summary
aibolit/main.py Refactored run_thread to collect and return a list of results, added per-future exception handling.

Poem

In threads we hop, results we find,
Now gathered neatly, all combined.
If one should stumble, we don’t fall—
We catch the slip and log it all.
A basket full, not one by one,
Our work is shared, our task is done!
🐇✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93a1606 and 31bac4d.

📒 Files selected for processing (1)
  • aibolit/__main__.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • aibolit/main.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: latexmk
  • GitHub Check: make
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0crat
Copy link
Collaborator

0crat commented Jul 20, 2025

@MMenshikh Hey there! 👋 I noticed your branch name improve-error-handling doesn't quite follow our naming convention. It's not ideal and unfortunately, that means a -12 point penalty. 😕 Next time, try using the ticket number instead - something like 880 would be perfect! It helps keep things organized and aligns with our policy. Let's work on this together to avoid future penalties and keep our workflow smooth. 🚀

@ivanovmg
Copy link
Contributor

@MMenshikh thank you for the PR! I think it is very helpful, however I recommend that you create a bug report with a proper description of the problem and the expected results. Then you can reference this issue in the PR description for better traceability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants