-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple ordering of POST calls by resource type #534
Open
echicoine-icf
wants to merge
9
commits into
cqframework:master
Choose a base branch
from
echicoine-icf:POST-order-by-resource-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simple ordering of POST calls by resource type #534
echicoine-icf
wants to merge
9
commits into
cqframework:master
from
echicoine-icf:POST-order-by-resource-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es can be posted in specific order together.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
============================================
+ Coverage 21.85% 21.97% +0.11%
- Complexity 1673 1681 +8
============================================
Files 297 297
Lines 25392 25432 +40
Branches 4004 4011 +7
============================================
+ Hits 5550 5588 +38
+ Misses 18922 18920 -2
- Partials 920 924 +4 ☔ View full report in Codecov by Sentry. |
…ogger.info messages for readability.
…or each type of resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Refresh and specifying a FHIR server to persist the resources to, I found resources that would fail in the initial attempt, but POST in the second attempt, indicating a dependency on some other resource to POST first. I've identified an order for these resources to be posted in: Bundle, Library Dependencies, Value Sets, Tests, and Patient Group files. With this grouping of resources and creating an order in which they are sent to the server, the initial attempt at posting the resources is far more successful and consistent.
When calling HttpClientUtils.post, the enum HttpPOSTResourceType can be specified. When executing the tasks, HttpClientUtils.resourceTypePostOrder is used to execute each group of tasks in the order specified.