Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX (Issue 537): ExtractMatBundle Non-IG Folder Structure Handling #539

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

echicoine-icf
Copy link
Contributor

@echicoine-icf echicoine-icf commented Nov 21, 2024

When ExtractMATBundle operation is ran against bundle inside non-IG structured directory, errors were encountered and the processed terminated.

This change enhances the bundles folder identification process, and if no bundle folder is found where a parent folder structure can be established, the output folder becomes same as the location of the bundle file itself.

Other modifications include using Paths and File.separator for OS compatibility, and creating a directory where none exists only when outputResourceByName is called or CQL is extracted.

New test moves files from "bundles_small" test folder to temporary folder NOT named with "bundles", and does not specify an output folder. The result are all files extracted within that same temporary folder (source of bundle json.)

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

Evan Chicoine added 5 commits November 20, 2024 14:30
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 21.90%. Comparing base (955f07e) to head (fd1f3d8).

Files with missing lines Patch % Lines
...f/tooling/operation/ExtractMatBundleOperation.java 52.00% 6 Missing and 6 partials ⚠️
...g/opencds/cqf/tooling/utilities/ResourceUtils.java 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #539      +/-   ##
============================================
+ Coverage     21.87%   21.90%   +0.02%     
- Complexity     1673     1680       +7     
============================================
  Files           297      297              
  Lines         25412    25430      +18     
  Branches       4008     4015       +7     
============================================
+ Hits           5560     5571      +11     
- Misses        18931    18936       +5     
- Partials        921      923       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant