-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG FIX (Issue 537): ExtractMatBundle Non-IG Folder Structure Handling #539
Open
echicoine-icf
wants to merge
10
commits into
cqframework:master
Choose a base branch
from
echicoine-icf:issue537
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r structure is not present.
…xtraction (output) after ig folder structure check fails to provide directory. Test updated to verify bundles folder no longer needed for extraction.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
============================================
+ Coverage 21.87% 21.90% +0.02%
- Complexity 1673 1680 +7
============================================
Files 297 297
Lines 25412 25430 +18
Branches 4008 4015 +7
============================================
+ Hits 5560 5571 +11
- Misses 18931 18936 +5
- Partials 921 923 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ExtractMATBundle operation is ran against bundle inside non-IG structured directory, errors were encountered and the processed terminated.
This change enhances the bundles folder identification process, and if no bundle folder is found where a parent folder structure can be established, the output folder becomes same as the location of the bundle file itself.
Other modifications include using Paths and File.separator for OS compatibility, and creating a directory where none exists only when outputResourceByName is called or CQL is extracted.
New test moves files from "bundles_small" test folder to temporary folder NOT named with "bundles", and does not specify an output folder. The result are all files extracted within that same temporary folder (source of bundle json.)
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0