Add search icon and use in search input, darken border, update shortc… #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut to use modifier key
Contributor
Author
|
@AugustMiller I'm curious if you'd suggest putting the quotation marks in a different place around this shortcut, or if it looks okay as-is: |
✅ Deploy Preview for craft-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This is way more complicated than it needed to be… in reality, we could probably just check for `macOS` in the user agent and call it a day.
Contributor
|
Attempted to make this platform-aware: 
I assume the quotes around the The metrics on this font are all wonky! At some point, maybe we can provide a supplemental label via a key-like UI element, like this: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut to use modifier key
Description
Related issues
Resolves PT-1071, PT-1068