Skip to content

Docs: index.rst: Minor page tuning #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

Docs: index.rst: Minor page tuning #889

merged 3 commits into from
May 14, 2025

Conversation

bmunkholm
Copy link
Contributor

@bmunkholm bmunkholm commented May 13, 2025

Summary of the changes / Why this is an improvement

Overall the intent is to remove any "noise" that before getting started.

  • GH admonition is secondary and is therefore moved to the bottom.
  • The local TOC is removed as it's redundant with the local TOC being in the right navbar now.
  • The Tip for using the Rest API isn't really so relevant here. If anything, we could consider it at the bottom, but why then not mention the CLI if it's alternatives we want to mention?

Preview

Before

image

After

image

@bmunkholm bmunkholm self-assigned this May 13, 2025
@bmunkholm bmunkholm changed the title index.rst: Move down GH admonition; remove local TOC index.rst: Minor page tuning. May 13, 2025
@bmunkholm bmunkholm requested a review from Copilot May 13, 2025 15:17
Copilot

This comment was marked as resolved.

@bmunkholm bmunkholm requested a review from amotl May 13, 2025 15:19
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment on lines -34 to -39
.. TIP::

If you access port ``4200`` via a client library or command-line tool
like ``curl`` or ``wget``, the request will be handled by the `CrateDB
Rest API`_, and the response will be in JSON.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it doesn't need to be priority information, but it is still viable information for readers of the documentation, and might just be relocated instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming this wasn't the only place this tip was provided, but more of a reference tip.
So I created an issue to consider where that should go in case it isn't mentioned somewhere else.

@amotl amotl changed the title index.rst: Minor page tuning. Docs: index.rst: Minor page tuning May 13, 2025
@bmunkholm bmunkholm merged commit cfbc272 into main May 14, 2025
4 checks passed
@bmunkholm bmunkholm deleted the bmunkholm-patch-1 branch May 14, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants