Upgrade tests to use Jetty 11#31
Merged
aecio merged 2 commits intocrawler-commons:masterfrom Aug 20, 2023
Merged
Conversation
aecio
force-pushed
the
jetty-11
branch
2 times, most recently
from
b19ccab to
f35014a
Compare
kkrugler
reviewed
Aug 20, 2023
| // Thread.sleep(2000); | ||
| // | ||
| // fetcher.get(url); | ||
| // } |
Contributor
There was a problem hiding this comment.
I would create an issue for this, and add the URL in your comment here.
kkrugler
approved these changes
Aug 20, 2023
Contributor
kkrugler
left a comment
kkrugler
left a comment
There was a problem hiding this comment.
Minor comment about filing an issue for the stale connection test.
Collaborator
Author
|
Thanks, @kkrugler! I'll create the issue and reference it before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the tests to Jetty 11. Since Jetty 11 requires Java 11, PR #30 must be merged before this.