feat(telegram): add support for topics #1305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will take another look at the initial implementation and let you know, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The continuation of #1125. Right now it is a direct copy of their work with open questions to be discussed.
This PR adds support for Telegram Chat Topics. For every Chat ID, one Topic can be provided. I've some minor changes planned for the code structure, but nothing that would change functionality.
Regarding the open code review, @crazy-max needs to let me know how to proceed with the implementation.
For these two reasons, the PR will remain a draft for now.
Note: Telegram calls it "Topics" in their UI and "Threads" in their API, therefor the code uses "Topics" when its userfacing and "Threads" in the code for easier cross-referencing with the API spec.
Closes #948 and #1031