Add semver option to watch_repo #1423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fetch the list of all tags from the repo, but exclude any that are a lower semver than the current tag. This also requires sort_tags to be semver as well.
IamTheFij
force-pushed
the
watch-repo-semver
branch
from
026e0a4 to
713cfa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fetch the list of all tags from the repo, but exclude any that are a lower semver than the current tag. This also requires sort_tags to be semver as well.
Use case for this is when a user always pins to a semver tag, eg
2.1.0. In that case, they need to watch for tags with a newer semver only. A new2.1.1tag should notify the user, however a patch release to an older1.9.1tag should not.Something I'm thinking about is how to handle this being set to
semverbut sorting not. Log and ignore, update default value, throw error if explicitly in conflict?