Add explicit additional step to the readme #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is just to set up a GPG key on GitHub but this is not a prerequisite. It can also be different following the provider (GitHub, Gitlab, ...). Maybe we can add a "Note" section in the readme to set this up for GitHub. |
Author
|
Sounds good...I'll amend this PR when I'm back from vacay (next week) |
crazy-max
requested changes
Sep 10, 2023
Owner
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
This is just to set up a GPG key on GitHub but this is not a prerequisite. It can also be different following the provider (GitHub, Gitlab, ...). Maybe we can add a "Note" section in the readme to set this up for GitHub.
^
lpmi-13
force-pushed
the
update_readme
branch
from
4a3c33f to
6d544b2
Compare
Author
|
hey there, sorry about forgetting to come back to this. Now updated to be in a separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was easy to miss during the process of setting up the action, and it would have been nice for it to be more explicit when we were setting this up.