Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, migrate to Fiber middlewares #199

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Update dependencies, migrate to Fiber middlewares #199

merged 1 commit into from
Jun 25, 2023

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Jun 25, 2023

Hello, GoFiber maintainer here! This PR is to update all the dependencies and also migrate to the new middlewares for JWT, Swagger.

Ping @koddr

All the linters/checks pass, the only thing not passing is two of the unit-tests as reported in #179

=== RUN   TestPrivateRoutes
    private_routes_test.go:108: 
        	Error Trace:	/home/ubuntu/Desktop/git/fix/fiber-go-template/pkg/routes/private_routes_test.go:108
        	Error:      	Not equal: 
        	            	expected: 400
        	            	actual  : 401
        	Test:       	TestPrivateRoutes
        	Messages:   	delete book without JWT and body
    private_routes_test.go:108: 
        	Error Trace:	/home/ubuntu/Desktop/git/fix/fiber-go-template/pkg/routes/private_routes_test.go:108
        	Error:      	Not equal: 
        	            	expected: 404
        	            	actual  : 500
        	Test:       	TestPrivateRoutes
        	Messages:   	delete book with credentials
--- FAIL: TestPrivateRoutes (0.03s)
=== RUN   TestPublicRoutes
    public_routes_test.go:66: 
        	Error Trace:	/home/ubuntu/Desktop/git/fix/fiber-go-template/pkg/routes/public_routes_test.go:66
        	Error:      	Not equal: 
        	            	expected: 404
        	            	actual  : 500
        	Test:       	TestPublicRoutes
        	Messages:   	get book by ID
--- FAIL: TestPublicRoutes (0.03s)
FAIL
	github.com/create-go-app/fiber-go-template/pkg/routes	coverage: 73.3% of statements
FAIL	github.com/create-go-app/fiber-go-template/pkg/routes	0.075s
FAIL

@welcome
Copy link

welcome bot commented Jun 25, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines.

@koddr koddr merged commit cac7d90 into create-go-app:master Jun 25, 2023
@welcome
Copy link

welcome bot commented Jun 25, 2023

Congrats on merging your first pull request! 🎉 We here at Create Go App are proud of you!

@gaby gaby deleted the updates branch June 25, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants