hotfix: add height width configurations for pretty vc and trim valida…

…tions for email identifier field Signed-off-by: bhavanakarwade <[email protected]>
credebl · Oct 14, 2024 · a748b53 · a748b53
1 parent 0435996
commit a748b53
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/apps/api-gateway/src/issuance/dtos/issuance.dto.ts b/apps/api-gateway/src/issuance/dtos/issuance.dto.ts
@@ -55,6 +55,18 @@ class PrettyVc {
   @Transform(({ value }) => trim(value))
   @IsString({ message: 'orientation must be in string format.' })
   orientation: string;
+
+  @ApiPropertyOptional({ example: '60px' })
+  @IsOptional()
+  @Transform(({ value }) => trim(value))
+  @IsString({ message: 'height must be in string format.' })
+  height?: string;
+
+  @ApiPropertyOptional({ example: '60px' })
+  @IsOptional()
+  @Transform(({ value }) => trim(value))
+  @IsString({ message: 'width must be in string format.' })
+  width?: string;
 }
 export class Credential {
   @ApiProperty()

diff --git a/apps/issuance/src/issuance.service.ts b/apps/issuance/src/issuance.service.ts
@@ -711,7 +711,9 @@ async outOfBandCredentialOffer(outOfBandCredential: OutOfBandCredentialOfferPayl
       prettyVc: {
         certificate: prettyVc?.certificate,
         size: prettyVc?.size,
-        orientation: prettyVc?.orientation
+        orientation: prettyVc?.orientation,
+        height: prettyVc?.height,
+        width: prettyVc?.width
       }
     };
 
@@ -1118,7 +1120,7 @@ async sendEmailForCredentialOffer(sendEmailCredentialOffer: SendEmailCredentialO
       if (0 >= parsedData.meta.fields.length) {
         throw new BadRequestException(ResponseMessages.bulkIssuance.error.emptyheader);
       }
-      const invalidEmails = parsedData.data.filter((entry) => !validateEmail(entry.email_identifier));
+      const invalidEmails = parsedData.data.filter((entry) => !validateEmail(entry.email_identifier.trim()));
 
       if (0 < invalidEmails.length) {
         throw new BadRequestException(ResponseMessages.bulkIssuance.error.invalidEmails);
@@ -1611,7 +1613,9 @@ async sendEmailForCredentialOffer(sendEmailCredentialOffer: SendEmailCredentialO
       prettyVc = {
         certificate: jobDetails?.certificate,
         size: jobDetails?.size,
-        orientation: jobDetails?.orientation
+        orientation: jobDetails?.orientation,
+        height: prettyVc?.height,
+        width: prettyVc?.width
       };
 
       oobIssuancepayload = await createOobJsonldIssuancePayload(JsonldCredentialDetails, prettyVc);

diff --git a/libs/common/src/interfaces/issuance.interface.ts b/libs/common/src/interfaces/issuance.interface.ts
@@ -85,6 +85,8 @@ export interface IIssuedCredential {
       certificate: string;
       size: string;
       orientation: string;
+      height?: string;
+      width?: string;
     }
 
     interface ICredentialSubject {