Fix vault filtering returning empty results

[Copilot]

Vault filtering/searching was completely broken - all searches returned empty results regardless of query.

works as expeected:

Root Cause

FilterService.Filter() created filtered subscription objects but discarded them immediately, then passed an empty list to the sort function:

// Before: filtered results were created but never collected
foreach (var subscription in allSubscriptions)
{
    // ... filtering logic ...
    if (filteredResourceGroups.Count != 0)
    {
        var filteredSubscription = new KvSubscriptionModel { /* ... */ };
        new List<KvSubscriptionModel>().Add(filteredSubscription); // ❌ discarded
    }
}
var sortedSubscriptions = SortService.SortSubscriptions(new List<KvSubscriptionModel>()); // ❌ empty list

Changes

• Added filteredSubscriptions list to accumulate results
• Changed to add filtered subscriptions to the collection
• Pass collected subscriptions to sort function

// After: filtered results are properly collected and returned
var filteredSubscriptions = new List<KvSubscriptionModel>();
foreach (var subscription in allSubscriptions)
{
    // ... filtering logic ...
    if (filteredResourceGroups.Count != 0)
    {
        var filteredSubscription = new KvSubscriptionModel { /* ... */ };
        filteredSubscriptions.Add(filteredSubscription); // ✅ collected
    }
}
var sortedSubscriptions = SortService.SortSubscriptions(filteredSubscriptions); // ✅ actual results

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• av-build-tel-api-v1.avaloniaui.net
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/0.0.31/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/0.0.31/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Filtering/Searching of vaults is broken</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)