Disable large_pex support #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcuquemelle
reviewed
Sep 10, 2025
There was a problem hiding this comment.
This will break client code that still uses this option if cluster-pack is not pinned in all projects using it.
The thing is not about "this is not available by default in PEX", but that this option was mandatory with pex==2.1.137 to workaround pex not being executable if > 2GB.
If you completely remove the support, you need to ensure that all clients pin cluster-pack to the previous version, or update all code that uses this option.
It might be simpler to first relax the constraint on pex to >=1.1.137<2.50 (2.50 has not been tested), release a new version so that you decouple updating all clients and removing the large pex support later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.