Add lock to prevent update failed package to be re-executed #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a package failed to install, command-launcher try to re-update it each time a command is executed.
This PR prevent failed packages to be re-updated, except if
update --packageis explicitly executed.Description
A lock file
.update-lockis created in package folder if package setup failed.This lock file prevent update of this package, new version is ignored silently.
If the user want to override lock file, it can be deleted manually or forced by explicit
update --package. The backup mechanism refresh the package folder and remove the lock file if setup is successful. If not, update lock file is restored.Missing documentation and tests