hwbench: fix monitoring loop when late #101
Open
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please explain the issue and the solution in the commit message so our futur "us" will be able to understand this change. |
This should fix the monitoring loop when we are late and make the code a bit easier to read. Before this change, the code would loop indefinitely if an iteration of the monitoring was late by more than 500ms. Check that there is still time to run based on the current time, not a calculation based on the current loop runtime. And return if there is no time, ignoring the negative sleep time.
ErwanAliasr1
requested changes
Oct 21, 2025
| sleep_time = sleep_time_ns / 1e9 # in seconds | ||
|
|
||
| if sleep_time_ms < -5: | ||
| # The iteration is already late on schedule, no need to sleep |
There was a problem hiding this comment.
We should remove the "no need to sleep" as we don't take the decision here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the monitoring loop when we are late and make the code a bit easier to read.