README: Explicit the main requirements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2024
Closed
This was referenced May 23, 2024
Closed
Closed
Closed
anisse
reviewed
May 23, 2024
|
|
||
| # Requirements | ||
| ## Mandatory | ||
| - python >= 3.9 |
There was a problem hiding this comment.
Don't we want to document the runtime python dependencies? Or maybe link to requirements/base.in ?
There was a problem hiding this comment.
I asked myself the same question.
Maybe linking is better
There was a problem hiding this comment.
Let's add the link in another commit/PR.
There was a problem hiding this comment.
Why in another PR ?
There was a problem hiding this comment.
Just in case. Works with this PR.
anisse
approved these changes
May 24, 2024
|
|
||
| # Requirements | ||
| ## Mandatory | ||
| - python >= 3.9 |
There was a problem hiding this comment.
Let's add the link in another commit/PR.
When people discover the project, it's cool to give a quick overview of what are the dependencies to make this project being used. Signed-off-by: Erwan Velu <[email protected]>
anisse
approved these changes
May 24, 2024
|
|
||
| # Requirements | ||
| ## Mandatory | ||
| - python >= 3.9 |
There was a problem hiding this comment.
Just in case. Works with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When people discover the project, it's cool to give a quick overview of what are the dependencies to make this project being used.