Skip to content

Conversation

Arno500
Copy link
Contributor

@Arno500 Arno500 commented Aug 1, 2025

This is useful for our performance score calculator and is generally a good metric to dump I think

Copy link
Collaborator

@ErwanAliasr1 ErwanAliasr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you aim at dumping memory information in a matter of computing performance metric, the memory architecture of the machine should be collected.

Adding the memory module dump in the existing dmi code is probably the way to go, adding the memory hierarchy (with hwloc) is also probably a good idea.

I really don't understand how you want to correlate proc/meminfo with performance.

@Arno500
Copy link
Contributor Author

Arno500 commented Aug 14, 2025

If you aim at dumping memory information in a matter of computing performance metric, the memory architecture of the machine should be collected.

Adding the memory module dump in the existing dmi code is probably the way to go, adding the memory hierarchy (with hwloc) is also probably a good idea.

I really don't understand how you want to correlate proc/meminfo with performance.

It's more about getting an "amount" than actual performance. The performance metrics related to memory shall be tested in benchmarks and the architectural difference should be included in the benchmark results.

About DMI, I thought about it but:

  • it does not work in all environments (for instance, does not work in WSL/Hyper-V it seems, what about other hypervisors?)
  • it does not include all forms of actual usable memory (like CXL or swap? No idea of what kind of memory will exist in the future)
  • it may possibly be badly integrated by OEMs, or be plain wrong

I still think it could be a good idea FAR, that said

@Arno500 Arno500 force-pushed the memory-info branch 3 times, most recently from 0bc5178 to 003d8e3 Compare August 14, 2025 11:56
@Arno500 Arno500 force-pushed the memory-info branch 3 times, most recently from 6f2ce80 to 17721bd Compare September 2, 2025 14:12
Copy link
Contributor

@anisse anisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is useful for our performance score calculator and is generally a good metric to dump I think
@Arno500 Arno500 dismissed ErwanAliasr1’s stale review September 3, 2025 14:27

DMI can be added in another review, included memstat in "software" environment

@Arno500 Arno500 merged commit a6afd9e into main Sep 3, 2025
4 checks passed
@Arno500 Arno500 deleted the memory-info branch September 3, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants