-
Notifications
You must be signed in to change notification settings - Fork 5
environment: include memory stats in the results #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you aim at dumping memory information in a matter of computing performance metric, the memory architecture of the machine should be collected.
Adding the memory module dump in the existing dmi code is probably the way to go, adding the memory hierarchy (with hwloc) is also probably a good idea.
I really don't understand how you want to correlate proc/meminfo with performance.
It's more about getting an "amount" than actual performance. The performance metrics related to memory shall be tested in benchmarks and the architectural difference should be included in the benchmark results. About DMI, I thought about it but:
I still think it could be a good idea FAR, that said |
0bc5178
to
003d8e3
Compare
6f2ce80
to
17721bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is useful for our performance score calculator and is generally a good metric to dump I think
DMI can be added in another review, included memstat in "software" environment
This is useful for our performance score calculator and is generally a good metric to dump I think