hwbench/HPE: Collect all thermal sensors #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thermal metrics are used in some hwgraph to study the thermal evolution during a given benchmark but also mixed with other metrics like fan speeds or power consumption. The current code avoids noisy graphs by limiting the thermal sensors list to CPU / DIMM & Inlet. In a recent study, while analyzing Fan's behavior, it was impossible to study the impacts of an increased rotation speeds on other components like VR or OCP Nics. HPE servers usually has ~20 sensors being reported in the redfish endpoints and not collecting them prevents deeper thermal analysis. Instead of filtering components in hwbench, let's collect all the sensors and let hwgraph filter out some if needed. Dell's specific code is not filtering thermal sensors, so removing this HPE-specific code will unify rendering across vendors. This commit: - removes the explicit component filtering - collects all thermal sensors - update the test suite to match this new behavior A dedicated hwgraph commit will come later to manage the thermal filtering. Signed-off-by: Erwan Velu <[email protected]>
Did you make progress on this front? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thermal metrics are used in some hwgraph to study the thermal evolution during a given benchmark but also mixed with other metrics like fan speeds or power consumption.
The current code avoids noisy graphs by limiting the thermal sensors list to CPU / DIMM & Inlet.
In a recent study, while analyzing Fan's behavior, it was impossible to study the impacts of an increased rotation speeds on other components like VR or OCP Nics.
HPE servers usually has ~20 sensors being reported in the redfish endpoints and not collecting them prevents deeper thermal analysis.
Instead of filtering components in hwbench, let's collect all the sensors and let hwgraph filter out some if needed.
Dell's specific code is not filtering thermal sensors, so removing this HPE-specific code will unify rendering across vendors.
This commit:
A dedicated hwgraph commit will come later to manage the thermal filtering.