Skip to content

fix(ci): fix commitlint and update ruff config #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix(ci): fix commitlint and update ruff config #47

merged 1 commit into from
Jul 31, 2025

Conversation

djothi
Copy link
Contributor

@djothi djothi commented Jul 31, 2025 •
edited
Loading

Description:

This PR includes the following fixes for the CI:

  • fix commitlint setup:
    • Upgraded ⁠actions/checkout from ⁠v3 to ⁠v4 for better performance and security.
    • Switched from manual Node.js setup to ⁠actions/setup-node@v4 with ⁠node_version: 'latest'
  • update ruff config to ignore new lint errors after upgrade: Updates the ⁠pyproject.toml configuration to address new lint errors introduced after upgrading ruff. Specifically, the following error codes have been added to the ignore list:

    • PLC0415: import-outside-top-level

    • PLW1508: invalid type for environment variable default

@djothi
fix(ci): fix commitlint and update ruff config to ignore new lint err…
28cdc15 
…ors after upgrade

Notes:
- fix commitlint
- update ruff config to ignore new lint errors after upgrade
@djothi djothi force-pushed the update_pyproject.toml branch from c579631 to 28cdc15 Compare July 31, 2025 09:44
@djothi djothi changed the title fix: update ruff config to ignore new lint errors after upgrade fix(ci): fix commitlint and update ruff config to ignore new lint errors after upgrade Jul 31, 2025
@djothi djothi requested a review from a team July 31, 2025 09:52
@djothi djothi changed the title fix(ci): fix commitlint and update ruff config to ignore new lint errors after upgrade fix(ci): fix commitlint and update ruff config Jul 31, 2025
@djothi djothi self-assigned this Jul 31, 2025
@djothi djothi merged commit 633ca4c into criteo:main Jul 31, 2025
2 checks passed
@djothi djothi deleted the update_pyproject.toml branch July 31, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpetremann kpetremann kpetremann approved these changes

Assignees

@djothi djothi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djothi @kpetremann