Skip to content

Add 30s client timeout on HealthHook http calls #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

Add 30s client timeout on HealthHook http calls #74

merged 2 commits into from
Aug 27, 2025

Conversation

damsallem
Copy link
Contributor

  • It's a failsafe one in case an external dep is unresponsive

Add 30s client timeout on HealthHook http calls
f4d5a26 
* It's a failsafe one in case an external dep is unresponsive
geobeau
geobeau requested changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@geobeau geobeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except if you need to push it ASAP. I would make it configurable: at the moment we don't know how often a hook reaches 30s so it might break.

@damsallem damsallem merged commit b35a833 into criteo:main Aug 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geobeau geobeau geobeau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damsallem @geobeau