Skip to content

Refactor template canvas #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 4, 2025
Merged

Refactor template canvas #18

merged 28 commits into from
Apr 4, 2025

Conversation

marcospassos
Copy link
Member

@marcospassos marcospassos commented Apr 4, 2025

Summary

CSS styles are currently being inserted as plain text, causing React to escape HTML characters and break the styling. This PR updates the logic to inject raw CSS using dangerouslySetInnerHTML, ensuring the styles are applied correctly.

This PR also adds a feature that allows the canvas to self embed the current page, including a Next-specific component.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the bug Something isn't working label Apr 4, 2025
Copy link

github-actions bot commented Apr 4, 2025

👋 @marcospassos
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

Copy link

pkg-pr-new bot commented Apr 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@croct/template-ui@18

commit: 59e6c49

Copy link

github-actions bot commented Apr 4, 2025

🔥 Here is the preview of the pull request:
https://preview.template-ui.croct.dev/pr-18

@marcospassos marcospassos requested a review from a team as a code owner April 4, 2025 19:35
@marcospassos marcospassos changed the title Fix CSS injection Refactor template canvas Apr 4, 2025
@marcospassos marcospassos merged commit 257f6ff into master Apr 4, 2025
@marcospassos marcospassos deleted the fix-css-injection branch April 4, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants