Skip to content

Add support for specifying target #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Add support for specifying target #20

merged 1 commit into from
Apr 10, 2025

Conversation

marcospassos
Copy link
Member

Summary

This PR adds support for specifying a target for buttons.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the feature New feature label Apr 10, 2025
@marcospassos marcospassos requested a review from Copilot April 10, 2025 21:59
Copy link

👋 @marcospassos
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/react/LinkButton/index.tsx:52

  • When target is '_blank', consider also setting a rel attribute (e.g., rel='noopener noreferrer') to enhance security.
target={target}

Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@croct/template-ui@20

commit: ae70c35

Copy link

🔥 Here is the preview of the pull request:
https://preview.template-ui.croct.dev/pr-20

@marcospassos marcospassos merged commit eeb3183 into master Apr 10, 2025
10 checks passed
@marcospassos marcospassos deleted the target branch April 10, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant