Skip to content

Add CTA target to template canvas #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

tiagobarros01
Copy link
Member

@tiagobarros01 tiagobarros01 commented Apr 14, 2025

Summary

⭐️ This Pull request adds a new prop to the TemplateCanvas component to specify the target of the CTA link.


👀 Preview

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@tiagobarros01 tiagobarros01 self-assigned this Apr 14, 2025
Copy link

👋 @tiagobarros01
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

Copy link

pkg-pr-new bot commented Apr 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@croct/template-ui@21

commit: 0a20c2c

@tiagobarros01 tiagobarros01 added the feature New feature label Apr 14, 2025
Copy link

🔥 Here is the preview of the pull request:
https://preview.template-ui.croct.dev/pr-21

@marcospassos marcospassos merged commit 8907132 into master Apr 14, 2025
8 checks passed
@marcospassos marcospassos deleted the feat/add-target-template-canvas branch April 14, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants