Skip to content

Allow user to specify name before creating a new entity #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

martin-fleck-at
Copy link
Collaborator

No description provided.

@martin-fleck-at martin-fleck-at force-pushed the issue/named-entity branch 2 times, most recently from 9f485d0 to 40c144e Compare April 10, 2025 13:51
Copy link

github-actions bot commented Apr 10, 2025

Unit Test Results

43 tests   43 ✅  44s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit ad3f40d.

♻️ This comment has been updated with latest results.

@martin-fleck-at martin-fleck-at force-pushed the issue/named-entity branch 2 times, most recently from 6b68012 to 2a50798 Compare April 10, 2025 14:20
@harmen-xb
Copy link
Contributor

@martin-fleck-at Thanks for the change, it works good.

One question, in the object creation flow story we talked about have field be shown in the diagram canvas at the position where was clicked to enter the name. Something like:
image

Is this easily possible? Cause I think from end-user this is more user friendly.

@martin-fleck-at
Copy link
Collaborator Author

@harmen-xb You are absolutely correct that this would have been a bit nicer and that was what I was aiming for first. Unfortunately, it requires more infrastructure (because we need the validation cycle) and also is a bit harder to deal with since we are always in continuous mode (i.e., the user can just continue to clicking on the diagram and create new entities) and we would need to prevent that or assume that it is canceling the input. Since the dialog gave us all of that for free, I went for the "cheaper" option but I can look into it deeper if you want. Now as I am writing this, maybe it already help to simply position the dialog a bit better and make it look more like a single text input through CSS. We still need to have it modal (I believe) but it might lead to nicer UX. Will look quickly into it.

@harmen-xb
Copy link
Contributor

@martin-fleck-at For now this is fine. Just checking whether it was an easy option.

@harmen-xb harmen-xb force-pushed the issue/named-entity branch 2 times, most recently from 8d0c143 to 02685de Compare April 10, 2025 22:38
@harmen-xb harmen-xb force-pushed the issue/named-entity branch from 02685de to cfc92e3 Compare April 10, 2025 22:51
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed look good!

@harmen-xb harmen-xb merged commit 7b4bcd1 into main Apr 11, 2025
6 checks passed
@harmen-xb harmen-xb deleted the issue/named-entity branch April 11, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants