-
Notifications
You must be signed in to change notification settings - Fork 5
Allow user to specify name before creating a new entity #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f485d0
to
40c144e
Compare
Unit Test Results43 tests 43 ✅ 44s ⏱️ Results for commit ad3f40d. ♻️ This comment has been updated with latest results. |
6b68012
to
2a50798
Compare
@martin-fleck-at Thanks for the change, it works good. One question, in the object creation flow story we talked about have field be shown in the diagram canvas at the position where was clicked to enter the name. Something like: Is this easily possible? Cause I think from end-user this is more user friendly. |
@harmen-xb You are absolutely correct that this would have been a bit nicer and that was what I was aiming for first. Unfortunately, it requires more infrastructure (because we need the validation cycle) and also is a bit harder to deal with since we are always in continuous mode (i.e., the user can just continue to clicking on the diagram and create new entities) and we would need to prevent that or assume that it is canceling the input. Since the dialog gave us all of that for free, I went for the "cheaper" option but I can look into it deeper if you want. Now as I am writing this, maybe it already help to simply position the dialog a bit better and make it look more like a single text input through CSS. We still need to have it modal (I believe) but it might lead to nicer UX. Will look quickly into it. |
@martin-fleck-at For now this is fine. Just checking whether it was an easy option. |
8d0c143
to
02685de
Compare
02685de
to
cfc92e3
Compare
packages/glsp-client/src/browser/system-diagram/node-creation-tool/system-node-creation-tool.ts
Show resolved
Hide resolved
5166e9f
to
6365e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed look good!
No description provided.