Skip to content

fix: Allow same global ids if types are different #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

fix: Allow same global ids if types are different #144

merged 1 commit into from
May 26, 2025

Conversation

martin-fleck-at
Copy link
Collaborator

Fixes #134

@github-actions GitHub Actions
Copy link

github-actions bot commented May 26, 2025 •
edited
Loading

Unit Test Results

43 tests  ±0   43 ✅ ±0   42s ⏱️ -1s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 831fe39. ± Comparison against base commit a2943e8.

♻️ This comment has been updated with latest results.

@martin-fleck-at martin-fleck-at requested a review from harmen-xb May 26, 2025 12:23
harmen-xb
harmen-xb approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested and works as expected.

@harmen-xb harmen-xb merged commit 4f11a47 into main May 26, 2025
7 checks passed
@harmen-xb harmen-xb deleted the features/134 branch June 4, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harmen-xb harmen-xb harmen-xb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot have a diagram with the same id as an entity
2 participants
@martin-fleck-at @harmen-xb