Skip to content

fix: Ensure no error is thrown if there are no sources in a mapping #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

martin-fleck-at
Copy link
Collaborator

Fixes #143

Copy link

github-actions bot commented May 26, 2025

Unit Test Results

43 tests  ±0   43 ✅ ±0   44s ⏱️ -1s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c66e7c1. ± Comparison against base commit a2943e8.

♻️ This comment has been updated with latest results.

@harmen-xb
Copy link
Contributor

harmen-xb commented May 26, 2025

@martin-fleck-at I still see the issue.

When I have an entity with one or more attributes and I right click on the entity and choose 'Derive mapping' I get a mapping where the target attributes are already listed:

mapping:
    id: NewMapping2
    target:
        entity: Address
        mappings:
            - attribute: Customer_Id
            - attribute: Street
            - attribute: CountryCode

But if I right click on the model and choose 'New element > Mapping' and choose the same target entity the target attributes are not in the file (and the mapping diagram is not rendered correctly):

mapping:
    id: NewMapping
    target:
        entity: Address

I think it's best to solve this issue as part of #147, since mappings without listing the target attributes is already working there. As I mentioned in the other PR, I would rather not have the target attributes listed if there is no mapping on it.

@martin-fleck-at
Copy link
Collaborator Author

Sure, I'll have a look at this and merge it with the PR in #147

@harmen-xb harmen-xb deleted the features/143 branch May 27, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating mapping using 'New Element > Mapping' the target attributes are not in the file
2 participants