fix missing ToFieldPath in conversion

Signed-off-by: lsviben <[email protected]> (cherry picked from commit 15a1199)
crossplane-contrib · Jan 29, 2024 · c426a17 · c426a17
1 parent d1fa685
commit c426a17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/apis/object/v1alpha1/conversion.go b/apis/object/v1alpha1/conversion.go
@@ -69,6 +69,7 @@ func (src *Object) ConvertTo(dstRaw conversion.Hub) error { // nolint:golint //
 				FieldPath: r.PatchesFrom.FieldPath,
 			}
 		}
+		ref.ToFieldPath = r.ToFieldPath
 		references = append(references, ref)
 	}
 
@@ -148,6 +149,7 @@ func (dst *Object) ConvertFrom(srcRaw conversion.Hub) error { // nolint:golint,
 				FieldPath: r.PatchesFrom.FieldPath,
 			}
 		}
+		ref.ToFieldPath = r.ToFieldPath
 		references = append(references, ref)
 	}
 

diff --git a/apis/object/v1alpha1/conversion_test.go b/apis/object/v1alpha1/conversion_test.go
@@ -88,6 +88,7 @@ func TestConvertTo(t *testing.T) {
 									},
 									FieldPath: pointer.String("data.password"),
 								},
+								ToFieldPath: pointer.String("data"),
 							},
 						},
 						Readiness: v1alpha1.Readiness{Policy: v1alpha1.ReadinessPolicySuccessfulCreate},
@@ -133,6 +134,7 @@ func TestConvertTo(t *testing.T) {
 									},
 									FieldPath: pointer.String("data.password"),
 								},
+								ToFieldPath: pointer.String("data"),
 							},
 						},
 						Readiness: v1alpha2.Readiness{Policy: v1alpha2.ReadinessPolicySuccessfulCreate},
@@ -333,6 +335,7 @@ func TestConvertFrom(t *testing.T) {
 									},
 									FieldPath: pointer.String("data.password"),
 								},
+								ToFieldPath: pointer.String("data"),
 							},
 						},
 						Readiness: v1alpha2.Readiness{Policy: v1alpha2.ReadinessPolicySuccessfulCreate},
@@ -378,6 +381,7 @@ func TestConvertFrom(t *testing.T) {
 									},
 									FieldPath: pointer.String("data.password"),
 								},
+								ToFieldPath: pointer.String("data"),
 							},
 						},
 						Readiness: v1alpha1.Readiness{Policy: v1alpha1.ReadinessPolicySuccessfulCreate},