Skip to content

add support for int pointer references#610

Merged
phisco merged 1 commit intocrossplane:masterfrom
eljohnson92:support_int_pointers
Nov 30, 2023
Merged

add support for int pointer references#610
phisco merged 1 commit intocrossplane:masterfrom
eljohnson92:support_int_pointers

Conversation

@eljohnson92
Copy link
Contributor

@eljohnson92 eljohnson92 commented Nov 20, 2023

Description of your changes

This PR adds support for int64 pointer references. currently, string and float64 are supported. relevant crossplane-tools PR crossplane/crossplane-tools#60

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@eljohnson92 eljohnson92 requested review from a team as code owners November 20, 2023 17:52
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eljohnson92!

@eljohnson92
Copy link
Contributor Author

thanks for the thumbs up @phisco. fyi the corresponding crossplane-tools pr to support this is here

@phisco phisco merged commit 2cbf8d9 into crossplane:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants