fix: generate *float64 with convert import path #102
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Float64 pointer fields are not generated correctly using the latest version of corssplane-tools:
Example:
Where the import is :
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Replace in go.mod for
provider-upjet-ionoscloud
with the local copy with the changes. Test that the code is generated correctly.Ran tests in resolvers_test.go . These tests were failing before I made any changes:
I fixed those errors, but maybe someone can take a closer look at that field.
Note: There is another solution to use
convert
path for bothIsPointer
andIsFloatPointer
, but I saw thatconvert.FromPtrValue
in convert.go is deprecated in favor ofptr.Deref
.