feat: Migrate provider-template from cluster scope to namespaced scope #132
+566
−924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chuan-Yen Chiang <[email protected]>
Signed-off-by: Chuan-Yen Chiang <[email protected]>
cychiang
force-pushed
the
migrate-to-namespaced-provider
branch
from
35fd9db to
ab4303d
Compare
Signed-off-by: Chuan-Yen Chiang <[email protected]>
Signed-off-by: Chuan-Yen Chiang <[email protected]>
cychiang
force-pushed
the
migrate-to-namespaced-provider
branch
from
e511997 to
62d029c
Compare
|
hello Thanks for your contribution. I was just wondering if there is any plan on getting this PR merged any time soon? |
|
Hi @arashzz there are some minor things left to do and test, but will merge it soon. |
Signed-off-by: Chuan-Yen Chiang <[email protected]>
Signed-off-by: Chuan-Yen Chiang <[email protected]>
- Replace features with feature from crossplane-runtime - Remove external secret store support since v2 no longer support it Signed-off-by: Chuan-Yen Chiang <[email protected]>
cychiang
force-pushed
the
migrate-to-namespaced-provider
branch
from
5200ef5 to
961fc35
Compare
Signed-off-by: Chuan-Yen Chiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
ClusterProviderConfigProviderConfigto namespaced.MyTypeto namespaced.Please note that it works for Crossplane v2 and not backward compatible.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested