Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IsTty now that std::io::IsTerminal has stabalized. #794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Jul 11, 2023

Wasn't sure if the example/is_tty should remain, simply adapted it for now.

@TimonPost
Copy link
Member

Tho perhaps should wait a bit till removing it so that people not having upgraded yet being able to use it?

@sigmaSd
Copy link
Contributor

sigmaSd commented Jul 23, 2023

relevant helix-editor/helix#7605 (comment)

@LingMan
Copy link

LingMan commented Jul 22, 2024

A full year has passed and at least helix's MSRV concerns have resolved themselves. Do you think it would be fine to merge this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants