-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: force hub index file update if hub data upgrade is forced #3124
base: master
Are you sure you want to change the base?
Enhancement: force hub index file update if hub data upgrade is forced #3124
Conversation
@nox-x: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@nox-x: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3124 +/- ##
===========================================
+ Coverage 32.05% 49.87% +17.82%
===========================================
Files 320 321 +1
Lines 37662 37664 +2
===========================================
+ Hits 12073 18786 +6713
+ Misses 24287 17055 -7232
- Partials 1302 1823 +521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I ran into an issue by having a hub-index file younger than 24h within the docker container and needed to restart it while the hub holds newer data.
So this results in conflicting hashes for parsers loaded by a collection.
Setting the environment var
DO_HUB_UPGRADE
totrue
it just forces the already (old) indexed collections to upgrade, but not upgrading the index file.I think if someone forcing to get the newest data from the hub, than the local index should be as fresh as possible.
With this PR setting
DO_HUB_UPGRADE
totrue
also forces the local hub index to get updated on starting the docker container.