Skip to content

refact: remove unused metod DeleteDecisionsWithFilter() #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 2, 2025

No description provided.

Copy link

github-actions bot commented May 2, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented May 2, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.80%. Comparing base (4527ad0) to head (daeae34).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/database/decisions.go 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
+ Coverage   57.73%   57.80%   +0.07%     
==========================================
  Files         395      395              
  Lines       44082    44023      -59     
==========================================
- Hits        25450    25448       -2     
+ Misses      16501    16445      -56     
+ Partials     2131     2130       -1     
Flag Coverage Δ
bats 42.63% <47.05%> (+0.02%) ⬆️
unit-linux 33.06% <70.58%> (+0.08%) ⬆️
unit-windows 22.46% <11.76%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc added this to the 1.6.9 milestone May 2, 2025
@mmetc mmetc requested a review from blotus May 2, 2025 12:52
@mmetc mmetc merged commit 15dcbde into master May 6, 2025
16 checks passed
@mmetc mmetc deleted the deadcode branch May 6, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants