-
Notifications
You must be signed in to change notification settings - Fork 548
WAF: Add DropRequest helper to block request in hooks
#4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
/kind feature |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4016 +/- ##
==========================================
- Coverage 62.72% 62.72% -0.01%
==========================================
Files 416 416
Lines 32969 33136 +167
==========================================
+ Hits 20681 20783 +102
- Misses 10168 10215 +47
- Partials 2120 2138 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| interrupt = dropInfo.Interruption | ||
| } | ||
|
|
||
| if dropInfo != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge the ifs for clarity ?
Allow to manually block requests from a
pre_evalhook.This allows for example to easily implement geoblocking by reusing existing crowdsec helpers: