-
Notifications
You must be signed in to change notification settings - Fork 224
we need to initialize plugins as empty array #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
if you want to test rolldown in the playground, take react for example and update vite to:
and @vitejs/plugin-react to @vitejs/plugin-react-oxc
|
I added |
looks like the plugins are not being detected in build mode.
|
Yes, in rolldown-vite, the parameters in buildStart are not entirely identical to those in Vite. I'm currently unsure whether rolldown-vite doesn't support crxjs's syntax or if this is a bug in rolldown-vite. |
I think we can grab the plugins from this hook:
but even with that in place I'm still getting some errors when building. Same error for building vite6 and vite7 though. I think it might be related to the vite version miss-match in the repo
|
upgrading vite-plugin to at least 6 - and silencing some type errors solved the problems, and I managed to get |
@FliPPeDround just pushed the fixes. |
else you get this error: