feat(registration): implement wizard for additional configuration options#829
Draft
andrewazores wants to merge 16 commits intocryostatio:mainfrom
Draft
feat(registration): implement wizard for additional configuration options#829andrewazores wants to merge 16 commits intocryostatio:mainfrom
andrewazores wants to merge 16 commits intocryostatio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #792
See cryostatio/cryostat-web#2153 - similar eslint problem occurred here
Description of the change:
Adds a multi-step wizard component to the modal dialog that appears when users click the "Register with Cryostat" action on a Deployment on the Console's Topology view.
Previously the modal only allowed users to select from a list of detected Cryostat instances. If the selected instance was not an Operator-created instance (ie installed via Helm chart), registration would be blocked. No further customization was possible from this point.
Now, the modal appears with the wizard component displaying the first page as instance selection, which works much like before. The "Quick Register" footer button accepts all default values and completes the registration patching process. If further customization is desired, the user can click the "Next" button to proceed through the wizard, until the final review stage at which point the "Next" button now reads "Register" and completes the registration with any customization options the user selected.
Available customization options:
-javaagentflag. This defaults toJAVA_TOOL_OPTIONS, but now the user can customize this as necessary for their application/framework/base image.How to manually test: