feat(diagnostics): Add thread dumps endpoint and storage #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
reviewed
Jun 2, 2025
andrewazores
reviewed
Jun 2, 2025
andrewazores
reviewed
Jun 2, 2025
andrewazores
reviewed
Jun 2, 2025
andrewazores
reviewed
Jun 2, 2025
andrewazores
reviewed
Jun 4, 2025
andrewazores
reviewed
Jun 4, 2025
andrewazores
removed
the
needs-triage
andrewazores
changed the title
src/main/java/io/cryostat/diagnostic/BucketedDiagnosticsMetadataService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/diagnostic/BucketedDiagnosticsMetadataService.java
Outdated
Show resolved
Hide resolved
|
|
||
| public static final String METADATA_STORAGE_MODE_TAGGING = "tagging"; | ||
| public static final String METADATA_STORAGE_MODE_OBJECTMETA = "metadata"; | ||
| public static final String METADATA_STORAGE_MODE_BUCKET = "bucket"; |
There was a problem hiding this comment.
Note for later: this is duplicated between here and #927's ArchivedRecordingMetadataService, so we should do some refactoring after one of these PRs goes in and the other is rebased on top of it.
src/main/java/io/cryostat/recordings/LongRunningRequestGenerator.java
Outdated
Show resolved
Hide resolved
|
Rebase please. Could you also look at doing the refactoring mentioned in a previous comment? This is looking good from a read-over, so I'll give it a test run soon. |
src/main/java/io/cryostat/recordings/LongRunningRequestGenerator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #135
Initial implementation of thread dumps endpoint and storage setup/interaction
Opening as Draft until frontend is done since this will probably end up needing adjustments as that gets implemented.
TODO: Refactor (probably into a ThreadDumpHelper class like RecordingHelper)