chore(rest): replace WebClient with QuarkusRestClient #949
Conversation
andrewazores
added
breaking change
andrewazores
force-pushed
the
quarkus-rest-client
branch
3 times, most recently
from
7d9a393 to
fd3110a
Compare
andrewazores
removed
the
breaking change
andrewazores
force-pushed
the
quarkus-rest-client
branch
from
8ceb3ef to
92eb64d
Compare
|
/build_test |
|
Workflow started at 6/27/2025, 1:19:32 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: At least one test failed ❌ |
|
/build_test |
|
Workflow started at 6/27/2025, 4:56:41 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: At least one test failed ❌ |
1 similar comment
|
CI build and push: At least one test failed ❌ |
|
/build_test |
|
Workflow started at 6/27/2025, 7:56:02 PM. View Actions Run. |
|
CI build and push: At least one test failed ❌ |
|
No OpenAPI schema changes detected. |
andrewazores
force-pushed
the
quarkus-rest-client
branch
from
b9cb0e1 to
2a36dd1
Compare
|
This PR/issue depends on: |
|
/build_test |
|
Workflow started at 7/18/2025, 5:17:03 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes #778
Fixes #890
Discovered a bug in testing (#950) but this seems unrelated to this change.
Depends on #955
Based on #955
Depends on #961
Description of the change:
Refactors most usages of Vert.x
WebClientto useQuarkusRestClientinstead. This has a somewhat nicer interface to interact with, particular in the context of other Quarkus-isms, but most importantly it allows for unified client configuration using Quarkus properties.NOTE semi-breaking change:
grafana-datasource.urlconfig property is now namedquarkus.rest-client.jfr-datasource.url. The3249ee80d "grafana-datasource.url property compat"commit patches it for compatibility so that the previous old name can still be used, but it should be deprecated and the new name used going forward.Motivation for the change:
This enables a lot of configuration flexibility for HTTP-based connections from Cryostat to other components - reports sidecar, jfr-datasource, and agents.
How to manually test:
./smoketest.bash -O -t quarkus-cryostat-agent