fix(target-analysis): handle subscription on non-eventloop executor #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
|
This PR/issue depends on:
|
andrewazores
removed
the
needs-triage
|
/build_test |
|
Workflow started at 6/30/2025, 5:28:22 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: At least one test failed ❌ |
|
Failure looks like the typical one that should be fixed by #961 . |
This reverts commit a466c0f.
andrewazores
force-pushed
the
target-analysis-agent-2
branch
from
872674e to
b089f1d
Compare
Josh-Matsuoka
approved these changes
Jul 18, 2025
|
@Josh-Matsuoka have you also reviewed the changes in #949 which this is based on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #950
Based on #949
Depends on #949
Description of the change:
Prevents a hang (apparent deadlock) that results from the snapshot creation
Unisubscription being handled by the default Quarkus/Vert.x eventloop thread. Shuffling this work off to the default executor frees up the event loop and keeps things moving.How to manually test:
./smoketest.bash -O -t quarkus-cryostat-agenthttp://Quarkus/Cryostat Agent testing applicationAnalyzetoolbar button, then the process automation icon in the top right corner