-
Notifications
You must be signed in to change notification settings - Fork 10
fix(discovery): handle k8s IPv6 EndpointSlices #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0500b6d
to
e7754a3
Compare
/build_test |
Workflow started at 7/2/2025, 3:37:50 PM. View Actions Run. |
No GraphQL schema changes detected. |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I verified with single-stack IPv6 and single-stack IPv4 and target pods are registered as expected!
Just out of curiosity, are you able to test on dual stack? |
Unfortunately, I don't have a dual-stack cluster with me to test... I am trying with
|
…odname/namespace addresses
Seems like a flaky networking in |
/build_test |
Workflow started at 7/8/2025, 10:58:59 AM. View Actions Run. |
No GraphQL schema changes detected. |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ |
Updated: Worked fine on dualstack k8s cluster (via kubeadm). See more details at #71 (comment) |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #964
Description of the change:
true
) to apply a DNS name transformation to EndpointSlice addresses which are IPv4. Rather than using the simple direct IPv41.2.3.4
address as the hostname, the transformation changes this to the k8s DNS1-2-3-4.$namespace.pod
hostname. This seems to be useful for at least some network stacks, ex. inkind
.This doesn't actually fix IPv6 connectivity issues at the moment - connection failures further down in JMC code or even (apparently) in JDK RMI code occur. For that reason, this also:dualstack
clusters, where individual Pods/Services might have either or both IPv4/IPv6 addresses. This way, the IPv6 can be ignored and IPv4 used instead.Motivation for the change:
This change is helpful because users may want to...
How to manually test: